Mikas portfolio placeholder #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JennieDalgren
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Great job with the portfolio.
Nice with the subtle animations of the content when scrolling.
You have followed the design in a nice way but there are some places where your version differs from the Figma file. Take a look at the Figma file and go thru sizes and spacings thoroughly. For example the social media icons are way too small on mobile screen, which makes the user experience not so good, hard to press on those small icon-links.
Keep up the good work!
|
Fonts look better, but something seemed to have happened with your side spacing? All content go all the way on small mobile (320px width) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://mikaeberstein.netlify.app/